Socks5 in GW probe #6298
Socks5 in GW probe #6298
Conversation
|
Thank you for making this first PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
dynco-nym
force-pushed
the
dyn/gw-probe-socks5
branch
from
4b118a7 to
05448ab
Compare
dynco-nym
force-pushed
the
dyn/gw-probe-socks5
branch
from
05448ab to
e4948e6
Compare
| [package] | ||
| name = "nym-node-status-agent" | ||
| version = "1.0.7" | ||
| version = "1.0.8-gw-socks5" |
There was a problem hiding this comment.
does it make sense to annotate the version with gw-socks5 suffix? it will either have it or not. i.e. there wouldn't be 1.0.8 that does not have it
There was a problem hiding this comment.
this won't stay, I needed a version which wouldn't conflict with what we'll use in prod to build & deploy in a test env
|
|
||
| /// endpoint to test against | ||
| /// https://www.quicknode.com/docs/ethereum/web3_clientVersion | ||
| const TARGET_URL: &str = "https://docs-demo.quiknode.pro"; |
There was a problem hiding this comment.
why are we testing against this quite random website? why not something we control or something that's more used for this purpose
| ) -> anyhow::Result<ProbeResult> { | ||
| let exit_gateway = match gateway_key { | ||
| Some(gateway_key) => NodeIdentity::from_base58_string(gateway_key)?, | ||
| None => directory.random_exit_with_nr()?, |
There was a problem hiding this comment.
what's the point of testing a random gateway for socks5?
| if let Some(ref nr_details) = node_info.network_requester_details { | ||
| match do_socks5_connectivity_test( | ||
| &nr_details.address, | ||
| NymNetworkDetails::new_from_env(), |
| }; | ||
|
|
||
| info!("Waiting for network topology to be ready..."); | ||
| tokio::time::sleep(Duration::from_secs(10)).await; |
There was a problem hiding this comment.
couldn't we wait for some condition rather than always wait 10s? what if topology takes longer than that? (or way less than that)?
dynco-nym
modified the milestones:
Oscypek (est. mainnet 27.01.2026),
Parmigiano - Mainnet release 10th Feb
This change is